From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757945AbdKGQJD (ORCPT ); Tue, 7 Nov 2017 11:09:03 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:43141 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbdKGQJB (ORCPT ); Tue, 7 Nov 2017 11:09:01 -0500 X-Google-Smtp-Source: ABhQp+TI6KZc0Acgswnmj0GWmsBr9aWn6Oh4udx7Km7aK1Zr60TgJLh+Ge+iqPuba9t2RNEil7lm3w== From: Alexander Sverdlin Reply-To: Alexander Sverdlin To: Mengting Zhang , alexander.levin@verizon.com, ben@decadent.org.uk Cc: linux-kernel@vger.kernel.org, huawei.libin@huawei.com Subject: Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()' X-Mailer: Modest 3.90.7 References: <1510021460-27615-1-git-send-email-zhangmengting@huawei.com> In-Reply-To: <1510021460-27615-1-git-send-email-zhangmengting@huawei.com> Content-Type: text/plain; charset=utf-8 Content-ID: <1510071006.4450.12.camel@Nokia-N900> Date: Tue, 07 Nov 2017 17:10:07 +0100 Message-Id: <1510071007.4450.13.camel@Nokia-N900> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On Tue Nov  7 03:24:20 2017 Mengting Zhang wrote: > An annoying compile warning due to missing declaration is shown below: > In file included from lockdep.c:27:0: > ../../../kernel/locking/lockdep.c: In function > 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2: > warning: implicit declaration of function 'pr_cont' > [-Wimplicit-function-declaration]  pr_cont(") at:\n");  ^ > Adding the declaration of 'pr_cont' fixes the problem. > > Signed-off-by: Mengting Zhang Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective. But this is not related to your change, which I believe is correct: Reviewed-by: Alexander Sverdlin > --- >  tools/include/linux/lockdep.h | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/tools/include/linux/lockdep.h > b/tools/include/linux/lockdep.h index 8da3e8e..ae716ad 100644 > --- a/tools/include/linux/lockdep.h > +++ b/tools/include/linux/lockdep.h > @@ -47,6 +47,7 @@ static inline int debug_locks_off(void) >  #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__) >  #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__) >  #define pr_warn pr_err > +#define pr_cont pr_err >  >  #define list_del_rcu list_del >  > -- > 1.7.12.4 >