From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbdKIOZ3 (ORCPT ); Thu, 9 Nov 2017 09:25:29 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45043 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754810AbdKIOZ2 (ORCPT ); Thu, 9 Nov 2017 09:25:28 -0500 Message-ID: <1510237517.7659.10.camel@pengutronix.de> Subject: Re: [PATCH 1/9] ASoC: tlv320aic31xx: Fix typo in DT binding documentation From: Philipp Zabel To: "Andrew F. Davis" , Liam Girdwood , Mark Brown , Rob Herring , Mark Rutland , =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Shawn Guo , Sascha Hauer Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Thu, 09 Nov 2017 15:25:17 +0100 In-Reply-To: <20171108212505.28320-2-afd@ti.com> References: <20171108212505.28320-1-afd@ti.com> <20171108212505.28320-2-afd@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Wed, 2017-11-08 at 15:24 -0600, Andrew F. Davis wrote: > The property used to specify a GPIO intended for reset is "reset-gpio", > this binding uses "gpio-reset", as almost all other bindings use the > former name this use of the latter is certainly not intended and > was a typo. It is not compatible with newer methods used to fetch > GPIO pins and to prevent the spread of this error to other bindings > lets fix this here. > > We also standardize the pin as active-low, different device trees have > marked the GPIO different ways, luckily the driver currently uses the > low-level GPIO set function which does not respect the active-low flag, > but future changes may change this. This is an active-low reset, mark > it as such. > > Lastly, add an example of use for this property. > > Fixes: e00447fafbf7 ("ASoC: tlv320aic31xx: Add basic codec driver implementation") > > Signed-off-by: Andrew F. Davis > --- > Documentation/devicetree/bindings/sound/tlv320aic31xx.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt > index 6fbba562eaa7..4c4e77f97d87 100644 > --- a/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt > +++ b/Documentation/devicetree/bindings/sound/tlv320aic31xx.txt > @@ -22,7 +22,7 @@ Required properties: > > Optional properties: > > -- gpio-reset - gpio pin number used for codec reset I would move this into a "Deprecated properties:" section instead of just hiding it away. > +- reset-gpio - GPIO specification for the active low RESET input. This should be "reset-gpios". For reference, see Documentation/devicetree/bindings/gpio/gpio.txt. > - ai31xx-micbias-vg - MicBias Voltage setting > 1 or MICBIAS_2_0V - MICBIAS output is powered to 2.0V > 2 or MICBIAS_2_5V - MICBIAS output is powered to 2.5V > @@ -48,6 +48,7 @@ CODEC input pins: > The pins can be used in referring sound node's audio-routing property. > > Example: > +#include > #include > > tlv320aic31xx: tlv320aic31xx@18 { > @@ -56,6 +57,8 @@ tlv320aic31xx: tlv320aic31xx@18 { > > ai31xx-micbias-vg = ; > > + reset-gpio = <&gpio1 17 GPIO_ACTIVE_LOW>; > + > HPVDD-supply = <®ulator>; > SPRVDD-supply = <®ulator>; > SPLVDD-supply = <®ulator>; regards Philipp