mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Andrew F. Davis" <afd@ti.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin
Date: Thu, 09 Nov 2017 15:25:21 +0100	[thread overview]
Message-ID: <1510237521.7659.11.camel@pengutronix.de> (raw)
In-Reply-To: <20171108212505.28320-5-afd@ti.com>

On Wed, 2017-11-08 at 15:25 -0600, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpio", fix this here.
> 
> Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board")
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  arch/arm/boot/dts/am335x-pepper.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 03c7d77023c6..d652abd76333 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -139,7 +139,7 @@
>  &audio_codec {
>  	status = "okay";
>  
> -	gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>;
> +	reset-gpio = <&gpio1 16 GPIO_ACTIVE_LOW>;

This potentially breaks audio on am335x-pepper until the driver patches
are applied, same for the other device trees. To make this bisectable,
add support for the new property name to the driver before changing the
device trees.

regards
Philipp

  reply	other threads:[~2017-11-09 14:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 21:24 [PATCH 0/9] Remove use of "gpio-reset" from DT Andrew F. Davis
2017-11-08 21:24 ` [PATCH 1/9] ASoC: tlv320aic31xx: Fix typo in DT binding documentation Andrew F. Davis
2017-11-09 14:25   ` Philipp Zabel
2017-11-09 16:28     ` Andrew F. Davis
2017-11-08 21:24 ` [PATCH 2/9] ASoC: tlv320aic3x: " Andrew F. Davis
2017-11-09 20:26   ` [alsa-devel] " Benoît Thébaudeau
2017-11-09 20:42     ` Andrew F. Davis
2017-11-08 21:24 ` [PATCH 3/9] ASoC: cs42l56: bindings: sound: Fix reset GPIO name in example DT binding Andrew F. Davis
2017-11-13 21:20   ` Rob Herring
2017-11-08 21:25 ` [PATCH 4/9] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin Andrew F. Davis
2017-11-09 14:25   ` Philipp Zabel [this message]
2017-11-09 16:40     ` Andrew F. Davis
2017-11-08 21:25 ` [PATCH 5/9] ARM: dts: imx6: RDU2: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 6/9] ARM: dts: imx: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 7/9] ARM: dts: omap3-n900: " Andrew F. Davis
2017-11-08 21:25 ` [PATCH 8/9] ASoC: tlv320aic31xx: Fix the reset GPIO OF name Andrew F. Davis
2017-11-08 21:36   ` Mark Brown
2017-11-08 21:53     ` Andrew F. Davis
2017-11-08 22:18       ` Mark Brown
2017-11-08 23:25         ` Andrew F. Davis
2017-11-09 13:22           ` Mark Brown
2017-11-08 21:25 ` [PATCH 9/9] ASoC: tlv320aic3x: " Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510237521.7659.11.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=afd@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcousson@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®