From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbdKIPSM (ORCPT ); Thu, 9 Nov 2017 10:18:12 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:50334 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbdKIPSL (ORCPT ); Thu, 9 Nov 2017 10:18:11 -0500 X-Google-Smtp-Source: ABhQp+TVKISzNbZa5cP1MJ1QtGhFf6Fo9LKxFmKpuqiN8z8rbrb8+p+g1i2qctJjVRD75MmWxyAlXg== Message-ID: <1510240682.2849.128.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint From: Eric Dumazet To: Yafang Shao Cc: David Miller , Alexey Kuznetsov , yoshfuji@linux-ipv6.org, rostedt@goodmis.org, mingo@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 09 Nov 2017 07:18:02 -0800 In-Reply-To: References: <1510237564-6013-1-git-send-email-laoar.shao@gmail.com> <1510237564-6013-2-git-send-email-laoar.shao@gmail.com> <1510239161.2849.123.camel@edumazet-glaptop3.roam.corp.google.com> <1510239528.2849.126.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-09 at 23:11 +0800, Yafang Shao wrote: > I'm also very sad that I'm still using IPv4 in 2017 : ( > > Okay then another issue, > shoule we reduce the complexity in the function tcp4_seq_show() ? This is irrelevant really. I do not see how tcp4_seq_show() could avoid testing sk_state.