From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbdKKPEO (ORCPT ); Sat, 11 Nov 2017 10:04:14 -0500 Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:37069 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751278AbdKKPEN (ORCPT ); Sat, 11 Nov 2017 10:04:13 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:3872:3874:4250:4321:5007:7558:8957:10004:10400:10848:11026:11232:11473:11658:11914:12438:12530:12740:12760:12895:13069:13095:13311:13357:13439:14096:14097:14659:21080:21433:21434:21451:21627:30025:30054:30056:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bath49_5ec63e84ca05c X-Filterd-Recvd-Size: 1699 Message-ID: <1510412649.10883.12.camel@perches.com> Subject: Re: [PATCH 04/14] nubus: Fix log spam From: Joe Perches To: Finn Thain , Geert Uytterhoeven Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 11 Nov 2017 07:04:09 -0800 In-Reply-To: <0c2f94698a76d320786aac770d2db006fd4e5764.1510377368.git.fthain@telegraphics.com.au> References: <0c2f94698a76d320786aac770d2db006fd4e5764.1510377368.git.fthain@telegraphics.com.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-11-11 at 01:12 -0500, Finn Thain wrote: > Testing shows that a single Radius PrecisionColor 24X display board, > which has 95 functional resources, produces over a thousand lines of > log messages. Suppress these messages with pr_debug(). > Remove some redundant messages relating to nubus_get_subdir() calls. > Fix the format block debug messages which has the sequence of entries > backwards (my bad). > Move the "Scanning slots" message to its proper location. pr_debug calls are compiled completely away to nothing unless DEBUG is defined or CONFIG_DYNAMIC_DEBUG is enabled. Aren't some of these actually useful? Perhaps it'd be nicer to have some nubus specific flag to enable these outputs instead of relying on either #define DEBUG or CONFIG_DYNAMIC_DEBUG?