From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbbIJIp4 (ORCPT ); Thu, 10 Sep 2015 04:45:56 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:65155 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754681AbbIJIps (ORCPT ); Thu, 10 Sep 2015 04:45:48 -0400 From: Arnd Bergmann To: Peter Ujfalusi Cc: vinod.koul@intel.com, nsekhar@ti.com, linux@arm.linux.org.uk, olof@lixom.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH 09/21] ARM: davinci: Add set dma_mask to eDMA devices Date: Thu, 10 Sep 2015 10:45:12 +0200 Message-ID: <1510483.LNzviKQJ8l@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1441874270-2399-10-git-send-email-peter.ujfalusi@ti.com> References: <1441874270-2399-1-git-send-email-peter.ujfalusi@ti.com> <1441874270-2399-10-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iG3FDNy1Bt6PxGswtVcN1nNwb96z/Ul+l6Ntt2FbynfzIv2Nkyg bO2ZLXoWmUyV9m5kqYSAHfzWYwK2HVT26vc6Sdrsb32Z8NxRwJmKL1bz/EotxoaDmr6xiCL MTlpRVfDs00u3BoLyYyik0vSirS26t2znNkk5gpp5QSh3ACO3S++PCdlsqLyoxo8a/PS4BE SAute/YXjNwgzzWxhvFhA== X-UI-Out-Filterresults: notjunk:1;V01:K0:4XOKPELE/Tc=:zLlBBbyR67fxPt3sQkPpZI pIH+xhaxHBgGlvFPIPsilm6tP7j//gylcNC1Qq/rEa07LCtHVAyjtiz81efym9a8qEiwv2vNE DuWSrfsff2oQJaD1hjM+xrMHUWxgrIotTwEq/srRgxsioZY+QclIWZKiMEBaV+vymtHNkZsSx Yb4EXyL/i33BRyjTVM19ZP32tEKsINhLmIFDh+Mf12L9pJvXMxKgjbTD4ATSMa9Z1g0dx4GBd lZfs7uA0h5iKRcc1izmRzhlsAbGGRioBxDcF/knhlz2w5KeTJ+rpFq2VIiyRMXZbVHo+RBUXm W7vg1GAnQEM71BaVC+PKYVlPjskRXC+F+X9kWqYPxEx8e72wmsE8vrzD3TcR3Uvw9mVd54tbo HBl6IFZirf7A8ktQygqI3VjrpR5sJBOq4Y7B/HEgnyGuaP1E3S5ewuXgcNAgDLG+Ivp3XaIKY /fMQ0whAoObSl+fvbz4ZXVNxN2j0FuvuFhMWf2+c+pzsYa3NkmvTClNzsditoH47RuDPyxi/c sOScJwKbIN+bioDl3U+HE5WB5YTN3WcY1MC1RP3tm55foK6OaBTsPKP5k41T+vySNWl3TMJme TESFJLesgPkTaUbfDqotMQE5P9MirjbR+ecZGSbyB4ZK4jrbkL6PYaY35N3zLyFVlZ/lsps47 5cjfpfy4JKCDy+CkjTxjeIqIzg1FWnB3LqdpwvjtdSBuY2JMBISfqAulXJhnjYbCmIgVTlyCM tySR+8IbXZcyBFkw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 September 2015 11:37:38 Peter Ujfalusi wrote: > +static u64 da8xx_edma0_dmamask = DMA_BIT_MASK(32); > + > static struct platform_device da8xx_edma0_device = { > .name = "edma", > .id = 0, > .dev = { > .platform_data = &da8xx_edma0_pdata, > + .dma_mask = &da8xx_edma0_dmamask, > + .coherent_dma_mask = DMA_BIT_MASK(32), > }, > .num_resources = ARRAY_SIZE(da8xx_edma0_resources), > .resource = da8xx_edma0_resources, > }; While this is technically correct for all I can tell, could you convert it to use __initconst platform_device_info and platform_device_register_full() instead? statically declaring platform_devices has been frowned upon for a long time (even though a lot of arm platforms still do it), and statically declaring the dma mask seems worse to me (and yes, I realize we also do that elsewhere). Arnd