From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbdKLPjH (ORCPT ); Sun, 12 Nov 2017 10:39:07 -0500 Received: from m12-11.163.com ([220.181.12.11]:53410 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdKLPjF (ORCPT ); Sun, 12 Nov 2017 10:39:05 -0500 From: Pan Bian To: Andrew Lunn , Vivien Didelot , Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pan Bian Subject: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional Date: Sun, 12 Nov 2017 23:38:09 +0800 Message-Id: <1510501089-9451-1-git-send-email-bianpan2016@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: C8CowAAHZSLoaghabC+OPg--.34414S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrurykZrW5Ar43CFW7GFyfJFb_yoW3ZFg_Ka 47Zrn7uw4Fk3W2kr1rWayfXryFyr95Wrs3Zay0qrZ3tr9rG3WUJrykZF13Jw1Duw4UZF90 kFn3uF4ru39rKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU09NVDUUUUU== X-Originating-IP: [106.120.213.14] X-CM-SenderInfo: held01tdqsiiqw6rljoofrz/xtbBzw+OclaDwDVxYwAAsO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its return value should not be validated by a NULL check. Instead, use IS_ERR. Signed-off-by: Pan Bian --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index b471413..6d3fc8f 100644 --- a/drivers/net/dsa/lan9303-core.c +++ b/drivers/net/dsa/lan9303-core.c @@ -828,7 +828,7 @@ static void lan9303_probe_reset_gpio(struct lan9303 *chip, chip->reset_gpio = devm_gpiod_get_optional(chip->dev, "reset", GPIOD_OUT_LOW); - if (!chip->reset_gpio) { + if (IS_ERR(chip->reset_gpio)) { dev_dbg(chip->dev, "No reset GPIO defined\n"); return; } -- 1.9.1