From: Simranjit Singh <simranjit.singh@corebaby.org>
To: ibm-acpi@hmh.eng.br
Cc: dvhart@infradead.org, andy@infradead.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] Use checkpatch.pl to make thinkpad_acpi.c error free: octal permissions
Date: Tue, 14 Nov 2017 15:14:36 -0800 [thread overview]
Message-ID: <1510701276.9469.19.camel@k3saltt0> (raw)
From: Simranjit Singh <simranjit.singh@corebaby.org>
Using the checkpatch.pl script, there were 8 errors in thinkpad_acpi.c. I fixed them by changing permissions to octal,
and by adding parenthesis.
On the current tree, if you use checkpatch.pl, thinkpad_acpi.c will have 8 errors. With my changes, there are 0 errors.
However, I have added 3 new warnings.
I'm very new to kernel development, so if I messed up somewhere, please do tell me.
Changed binary permissions to octal in accordance with checkpatch.pl in thinkpad_acpi.c
Signed-off-by: Simranjit Singh <simranjit.singh@corebaby.org>
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 2242d60..9ad1f5b 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9574,7 +9574,7 @@ static int __init set_ibm_param(const char *val, struct kernel_param *kp)
MODULE_PARM_DESC(experimental,
"Enables experimental features when non-zero");
-module_param_named(debug, dbg_level, uint, 0);
+module_param_named(debug, dbg_level, uint, 0444;
MODULE_PARM_DESC(debug, "Sets debug level bit-mask");
module_param(force_load, bool, 0444);
@@ -9638,25 +9638,25 @@ static int __init set_ibm_param(const char *val, struct kernel_param *kp)
#ifdef CONFIG_THINKPAD_ACPI_DEBUGFACILITIES
module_param(dbg_wlswemul, uint, 0444);
MODULE_PARM_DESC(dbg_wlswemul, "Enables WLSW emulation");
-module_param_named(wlsw_state, tpacpi_wlsw_emulstate, bool, 0);
+module_param_named(wlsw_state, tpacpi_wlsw_emulstate, 044);
MODULE_PARM_DESC(wlsw_state,
"Initial state of the emulated WLSW switch");
module_param(dbg_bluetoothemul, uint, 0444);
MODULE_PARM_DESC(dbg_bluetoothemul, "Enables bluetooth switch emulation");
-module_param_named(bluetooth_state, tpacpi_bluetooth_emulstate, bool, 0);
+module_param_named(bluetooth_state, tpacpi_bluetooth_emulstate, 0444);
MODULE_PARM_DESC(bluetooth_state,
"Initial state of the emulated bluetooth switch");
module_param(dbg_wwanemul, uint, 0444);
MODULE_PARM_DESC(dbg_wwanemul, "Enables WWAN switch emulation");
-module_param_named(wwan_state, tpacpi_wwan_emulstate, bool, 0);
+module_param_named(wwan_state, tpacpi_wwan_emulstate, 0444);
MODULE_PARM_DESC(wwan_state,
"Initial state of the emulated WWAN switch");
module_param(dbg_uwbemul, uint, 0444);
MODULE_PARM_DESC(dbg_uwbemul, "Enables UWB switch emulation");
-module_param_named(uwb_state, tpacpi_uwb_emulstate, bool, 0);
+module_param_named(uwb_state, tpacpi_uwb_emulstate, 0444);
MODULE_PARM_DESC(uwb_state,
"Initial state of the emulated UWB switch");
#endif
next reply other threads:[~2017-11-14 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 23:14 Simranjit Singh [this message]
2017-11-15 0:10 ` Randy Dunlap
2017-11-15 11:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510701276.9469.19.camel@k3saltt0 \
--to=simranjit.singh@corebaby.org \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®