From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756757AbdKOJo2 convert rfc822-to-8bit (ORCPT ); Wed, 15 Nov 2017 04:44:28 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39954 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756667AbdKOJoF (ORCPT ); Wed, 15 Nov 2017 04:44:05 -0500 Date: Wed, 15 Nov 2017 15:13:57 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes To: Satheesh Rajendran Cc: acme@kernel.org, bala24@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@kernel.org, srikar@linux.vnet.ibm.com References: <67b88aa2de6dd199d57bacdecf35d26958780feb.1503310062.git.sathnaga@linux.vnet.ibm.com> <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain> <1510663562.24275.38.camel@linux.vnet.ibm.com> In-Reply-To: <1510663562.24275.38.camel@linux.vnet.ibm.com> User-Agent: astroid/0.10.2 (https://github.com/astroidmail/astroid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17111509-0020-0000-0000-000003CC842C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111509-0021-0000-0000-00004261B7CC Message-Id: <1510738564.k2rtmh3mkn.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-15_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711150135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Satheesh, Satheesh Rajendran wrote: > Hi Naveen, > > > On Tue, 2017-10-31 at 20:46 +0530, Naveen N. Rao wrote: >>  >> >   } >> >   BUG_ON(nr_min > nr_max); >> > - >> Looks like an un-necessary change there. >> >> - Naveen >> > I had hit with this compilation error, so had to move the > initialization above. I suppose you intended to reply to Arnaldo's comment about the declaration being moved, since my comment above was about a blank line being deleted in your patch. It's preferable to not do any un-related changes/cleanups in a patch. > Please advice. Thanks. > >   CC       bench/numa.o > bench/numa.c: In function ‘calc_convergence’: > bench/numa.c:1035:3: error: ISO C90 forbids mixed declarations and code > [-Werror=declaration-after-statement] >    int processes = count_node_processes(node); >    ^ Not sure what changes you made, but from the error message, I'm guessing you placed the above statement _after_ the check for is_node_present(). What Arnaldo recommended is to retain the processes declaration within the scope where it's used - in this case, the for() loop - rather than moving it out to the start of the function. - Naveen > cc1: all warnings being treated as errors > mv: cannot stat ‘bench/.numa.o.tmp’: No such file or directory > make[4]: *** [bench/numa.o] Error 1 > make[3]: *** [bench] Error 2 > make[2]: *** [perf-in.o] Error 2 > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2 > > Regards, > -Satheesh. >> > >> >   BUG_ON(sum > g->p.nr_tasks); >> > >> >   if (0 && (sum < g->p.nr_tasks)) > @@ -1027,8 +1029,9 @@ static void calc_convergence(double >