From: Eugen Hristev <eugen.hristev@microchip.com>
To: <nicolas.ferre@microchip.com>,
<alexandre.belloni@free-electrons.com>,
<linux-iio@vger.kernel.org>, <lars@metafoo.de>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ludovic.desroches@microchip.com>, <jic23@kernel.org>
Cc: <eugen.hristev@microchip.com>
Subject: [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: ack DRDY irq in direct mode
Date: Wed, 15 Nov 2017 14:56:48 +0200 [thread overview]
Message-ID: <1510750608-8697-5-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1510750608-8697-1-git-send-email-eugen.hristev@microchip.com>
Need to acknowledge DRDY irq in direct mode/ software
triggered mode. Otherwise, on the next conversion, overrun
flag will be raised, which is not a correct state.
This doesn't affect the functionality, but will generate
possible incorrect overrun reports.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
drivers/iio/adc/at91-sama5d2_adc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 11d34a8..274cb5e 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -787,6 +787,9 @@ static int at91_adc_read_raw(struct iio_dev *indio_dev,
at91_adc_writel(st, AT91_SAMA5D2_IDR, BIT(chan->channel));
at91_adc_writel(st, AT91_SAMA5D2_CHDR, BIT(chan->channel));
+ /* Needed to ACK the DRDY interruption */
+ at91_adc_readl(st, AT91_SAMA5D2_LCDR);
+
mutex_unlock(&st->lock);
iio_device_release_direct_mode(indio_dev);
--
2.7.4
next prev parent reply other threads:[~2017-11-15 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 12:56 [PATCH v3 0/4] iio: adc: at91-sama5d2_adc: add DMA support Eugen Hristev
2017-11-15 12:56 ` [PATCH v3 1/4] dt-bindings: iio: at91-sama5d2_adc: add optional dma property Eugen Hristev
2017-11-15 15:27 ` Rob Herring
2017-11-18 16:07 ` Jonathan Cameron
2017-11-15 12:56 ` [PATCH v3 2/4] ARM: dts: at91: sama5d2: added dma property for ADC device Eugen Hristev
2017-11-29 21:05 ` Alexandre Belloni
2017-12-06 13:18 ` Eugen Hristev
2017-11-15 12:56 ` [PATCH v3 3/4] iio: adc: at91-sama5d2_adc: add support for DMA Eugen Hristev
2017-11-18 16:07 ` Jonathan Cameron
2017-11-15 12:56 ` Eugen Hristev [this message]
2017-11-19 11:28 ` [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: ack DRDY irq in direct mode Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510750608-8697-5-git-send-email-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome