From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbdKOVA4 (ORCPT ); Wed, 15 Nov 2017 16:00:56 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:50219 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757748AbdKOVAt (ORCPT ); Wed, 15 Nov 2017 16:00:49 -0500 X-Google-Smtp-Source: AGs4zMZvly3hBJENqpR+FbaCObO+SVoW0Epq41j2nF8+NYEDOWz2xAMAlOwQs8dODwi1AQimHTykog== From: Guenter Roeck To: Greg Kroah-Hartman Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org, Randy Dunlap , Wei-Ning Huang , Guenter Roeck Subject: [PATCH 1/3] firmware: vpd: Destroy vpd sections in remove function Date: Wed, 15 Nov 2017 13:00:43 -0800 Message-Id: <1510779645-13052-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vpd sections are initialized during probe and thus should be destroyed in the remove function. Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver") Signed-off-by: Guenter Roeck --- drivers/firmware/google/vpd.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index 35e553b3b190..84217172297b 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -298,8 +298,17 @@ static int vpd_probe(struct platform_device *pdev) return vpd_sections_init(entry.cbmem_addr); } +static int vpd_remove(struct platform_device *pdev) +{ + vpd_section_destroy(&ro_vpd); + vpd_section_destroy(&rw_vpd); + + return 0; +} + static struct platform_driver vpd_driver = { .probe = vpd_probe, + .remove = vpd_remove, .driver = { .name = "vpd", }, @@ -324,8 +333,6 @@ static int __init vpd_platform_init(void) static void __exit vpd_platform_exit(void) { - vpd_section_destroy(&ro_vpd); - vpd_section_destroy(&rw_vpd); kobject_put(vpd_kobj); } -- 2.7.4