From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758738AbdKOWdi (ORCPT ); Wed, 15 Nov 2017 17:33:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:44684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758642AbdKOWdS (ORCPT ); Wed, 15 Nov 2017 17:33:18 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2C282190E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org From: Alan Tull To: Greg Kroah-Hartman Cc: Moritz Fischer , Alan Tull , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 2/3] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get Date: Wed, 15 Nov 2017 16:33:11 -0600 Message-Id: <1510785192-10123-3-git-send-email-atull@kernel.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510785192-10123-1-git-send-email-atull@kernel.org> References: <1510785192-10123-1-git-send-email-atull@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Notice that bridge = to_fpga_bridge(dev); expands to: bridge = container_of(dev, struct fpga_bridge, dev); and container_of is never null, so this null check is unnecessary. Addresses-Coverity-ID: 1397912 Reported-by: Alan Tull Signed-off-by: Gustavo A. R. Silva Reviewed-by: Moritz Fischer Signed-off-by: Alan Tull --- drivers/fpga/fpga-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c index 4c48dd6..038b10b 100644 --- a/drivers/fpga/fpga-bridge.c +++ b/drivers/fpga/fpga-bridge.c @@ -78,8 +78,6 @@ static struct fpga_bridge *__fpga_bridge_get(struct device *dev, int ret = -ENODEV; bridge = to_fpga_bridge(dev); - if (!bridge) - goto err_dev; bridge->info = info; -- 2.7.4