From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758353AbdKOWzc (ORCPT ); Wed, 15 Nov 2017 17:55:32 -0500 Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:41843 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753936AbdKOWzX (ORCPT ); Wed, 15 Nov 2017 17:55:23 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2538:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3870:3873:4321:5007:6119:9040:10004:10400:10848:10967:11232:11658:11914:12295:12296:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21611:21627:30054:30064:30067:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: bells40_4bc2018a74947 X-Filterd-Recvd-Size: 1912 Message-ID: <1510786519.25299.7.camel@perches.com> Subject: Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c From: Joe Perches To: Steven Rostedt , Masami Hiramatsu , Jiri Kosina Cc: Song Liu , linux-kernel@vger.kernel.org, kernel-team@fb.com, trivial@kernel.org Date: Wed, 15 Nov 2017 14:55:19 -0800 In-Reply-To: <20171115131410.13a5a4c8@vmware.local.home> References: <20171113220246.4022518-1-songliubraving@fb.com> <20171114225831.4ecb6d02fc0fca718caa9f64@kernel.org> <20171115131410.13a5a4c8@vmware.local.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-15 at 13:14 -0500, Steven Rostedt wrote: > On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu wrote: > > On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu wrote: > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > > "trace_kprobe". > > Oh, good catch! > > Acked-by: Masami Hiramatsu > Thanks. > Acked-by: Steven Rostedt (VMware) > Jiri, can you take this in your tree? > [] > > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c [] > > > @@ -17,7 +17,7 @@ > > > * Copyright (C) IBM Corporation, 2010-2012 > > > * Author: Srikar Dronamraju > > > */ > > > -#define pr_fmt(fmt) "trace_kprobe: " fmt > > > +#define pr_fmt(fmt) "trace_uprobe: " fmt Maybe use the much more common below instead? #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt