From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935803AbdKPPu0 (ORCPT ); Thu, 16 Nov 2017 10:50:26 -0500 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:49274 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935243AbdKPPuU (ORCPT ); Thu, 16 Nov 2017 10:50:20 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2110:2393:2559:2562:2828:2902:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4250:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12050:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21220:21627:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: taste70_3c43ca0bbe34e X-Filterd-Recvd-Size: 1974 Message-ID: <1510847412.31559.25.camel@perches.com> Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats From: Joe Perches To: Harry Wentland , linux-kernel@vger.kernel.org Cc: Alex Deucher , David Airlie , dri-devel@lists.freedesktop.org, Christian =?ISO-8859-1?Q?K=F6nig?= , amd-gfx@lists.freedesktop.org Date: Thu, 16 Nov 2017 07:50:12 -0800 In-Reply-To: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com> References: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote: > On 2017-11-16 10:27 AM, Joe Perches wrote: > > Line continuations with excess spacing causes unexpected output. [] > > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence( > > if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) { > > ASSERT(0); > > dm_logger_write(link->ctx->logger, LOG_ERROR, > > - "%s: Link Training Error, could not \ > > - get CR after %d tries. \ > > - Possibly voltage swing issue", __func__, > > + "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue", > > Would probably be good to add a '\n' here as well but that's not the main intention of this patch. About 1/4 of the dm_logger_write calls are missing newlines and I think it should be a separate patch. I encourage you to fix them one day. > Reviewed-by: Harry Wentland cheers, Joe