From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932696AbdKQELe (ORCPT ); Thu, 16 Nov 2017 23:11:34 -0500 Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:39792 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932489AbdKQELZ (ORCPT ); Thu, 16 Nov 2017 23:11:25 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3868:3871:3872:4321:5007:7522:10004:10400:10848:11232:11658:11914:12050:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:14721:21080:21212:21433:21627:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: rod76_8098aa249a538 X-Filterd-Recvd-Size: 1519 Message-ID: <1510891882.28769.1.camel@perches.com> Subject: Re: [PATCH] regulator: tps65218: Add NULL test for devm_kzalloc call From: Joe Perches To: Axel Lin , Keerthy Cc: Mark Brown , Liam Girdwood , "linux-kernel@vger.kernel.org" , Linus Torvalds Date: Thu, 16 Nov 2017 20:11:22 -0800 In-Reply-To: References: <20171113125232.9672-1-axel.lin@ingics.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-17 at 11:58 +0800, Axel Lin wrote: > 2017-11-16 19:23 GMT+08:00 Keerthy : > > > > > > On Monday 13 November 2017 06:22 PM, Axel Lin wrote: > > > Signed-off-by: Axel Lin > > > > One line commit message would be better than blank commit message. > > It's just too trivial and checkpatch does not complain. I think trivial commits don't need commit messages if the subject line is sufficiently descriptive.