From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162814AbdKRGhN (ORCPT ); Sat, 18 Nov 2017 01:37:13 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:41923 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162777AbdKRGgw (ORCPT ); Sat, 18 Nov 2017 01:36:52 -0500 X-Google-Smtp-Source: AGs4zMZIOmjWbm8+HAEQBBRRyDOBvfDxEP/h7l4yWQ4eUhhMRFPaRFM2zRdUYLLUCXtM0Wv5JslHtg== From: Arvind Yadav To: lee.jones@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] mfd: intel-lpss: Handle return value of platform_get_* Date: Sat, 18 Nov 2017 12:06:32 +0530 Message-Id: <1510986993-4936-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510986993-4936-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510986993-4936-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mfd/intel-lpss-acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 7911b0a..cb84de5 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -92,6 +92,8 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev) info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); info->irq = platform_get_irq(pdev, 0); + if (!info->mem || info->irq < 0) + return -ENOMEM; pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); -- 2.7.4