From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947051AbdKRIsX (ORCPT ); Sat, 18 Nov 2017 03:48:23 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:40682 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947037AbdKRIsP (ORCPT ); Sat, 18 Nov 2017 03:48:15 -0500 X-Google-Smtp-Source: AGs4zMYF21S8aGbVFvW+nVDCnkSi1YY9OMk6H6f69uJmlOtwqz8J1uHIBX4/Qi5hwm+L7IHB6XA1Xw== From: Leo Yan To: Andy Whitcroft , Joe Perches , linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v3] checkpatch: Fix checks for Kconfig help text Date: Sat, 18 Nov 2017 16:48:01 +0800 Message-Id: <1510994881-9634-1-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If one patch has Kconfig section, the check script variable '$is_start' will be set by first 'config' line and the variable '$is_end' is to be set by the second 'config' line. But patches often has only one 'config' line so we have no chance to set '$is_end', as result below condition is invalid and it skips check for Kconfig description: if ($is_start && $is_end && $length < $min_conf_desc_length) { ...... } When script runs to this condition sentence it means the Kconfig section parsing has been completed, whatever '$is_end' is true or not. So removes '$is_end' from condition sentence. Signed-off-by: Leo Yan --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 95cda3e..6050323 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2796,7 +2796,7 @@ sub process { } $length++; } - if ($is_start && $is_end && $length < $min_conf_desc_length) { + if ($is_start && $length < $min_conf_desc_length) { WARN("CONFIG_DESCRIPTION", "please write a paragraph that describes the config symbol fully\n" . $herecurr); } -- 2.7.4