From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01415155C87; Mon, 27 Jan 2025 16:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737993889; cv=none; b=Y9IrfPJj8gw3V+UKKsOeZ1vVmPJnWkpt8j6aeMEmU+IHcE4ZnfP1O+MEirAKziL2eXAva0xntqLtWt1SUzIp9usv4mz7+vsNLuk6U/52lo7HsUS8X4ds1AnT81f0u73DOfPlmInxesjgFLFxSD7YOFWFKjI71n0j+6O94wyrMRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737993889; c=relaxed/simple; bh=7ET6BVX8ZQhudY1LxhOtxAAF9CiLaN5bQ+Ej7qLPLaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=quyfaTwrZ7Yv1YT13emitjgFLkYZubuHM0oNDkzNjXthZMeaj8Nzr8ZPRcXFcIhXCYLAYWuXd6KpYJ22pbNl74MJZdyn+RZ5tfbZD0HDIdFPO4SWtjule5qnu1GMk2RH4rDCRdH325pZJidq/1tkgYbWUvBAerV1vwc3mOqFM6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ySTOmZoW; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=bK2PMFIk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=zawGZfuv; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=r1CyFRsS; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ySTOmZoW"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bK2PMFIk"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="zawGZfuv"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="r1CyFRsS" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C7E151F383; Mon, 27 Jan 2025 16:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737993886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Doi5XPUCZ2nG9x2OZWRFRlVh/JHCmgk5nDDgwb+TmJ4=; b=ySTOmZoWjM9vn3Ai0JpWG/MEbXtGIx3QuCFgr84chqXUhAcq4KFxnUFae0Yjnl92eXBaos uLNNi0UM3iCtUzVQTcVFYkj8p1no/Fdg+1N+uScvB0z4IVHhcQRP//BJCz+aJUPTvJJl6P cXe9CrklU5oR/zJkSB1b+emHjQ7wCgI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737993886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Doi5XPUCZ2nG9x2OZWRFRlVh/JHCmgk5nDDgwb+TmJ4=; b=bK2PMFIki3eN7lB4Dr/NooL5SoFp6WG57uigv4ncJ4eo378O/zP1UDABJXv7pRouFCEC2+ 6iKXZ/akLAcoIfBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zawGZfuv; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r1CyFRsS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737993885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Doi5XPUCZ2nG9x2OZWRFRlVh/JHCmgk5nDDgwb+TmJ4=; b=zawGZfuv/UK6W2qQnAZ6mHhuWVeIfI02zDZPTgJhyo7iGRdoXE1YxoR7ydWwnFwR+n8uaX 8EcqH94DkSCDR+KOYAqUxrTVlYOqHW9hmFjIEzXMHfuxop+1+vHXUpMhCEvUb0ck+d6IiY pej6CFJktO2jqBNk2wfQ65wevsQSSXc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737993885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Doi5XPUCZ2nG9x2OZWRFRlVh/JHCmgk5nDDgwb+TmJ4=; b=r1CyFRsSi47QzxDz6FwCN6RR5cZLpphnfIDc7bLuWLwPyN3LmWrjVjt9ziO69eAFB6iqa4 XOorc8/TjCZjv3Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C8CA3137C0; Mon, 27 Jan 2025 16:04:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id H3d+Lpuul2e6egAAD6G6ig (envelope-from ); Mon, 27 Jan 2025 16:04:43 +0000 Message-ID: <151116ad-b671-4f4d-a231-6b2288d08158@suse.de> Date: Mon, 27 Jan 2025 18:04:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 -next 09/11] PCI: brcmstb: Fix for missing of_node_put To: Stanimir Varbanov , Florian Fainelli , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Broadcom internal kernel review list Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jim Quinlan , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , kw@linux.com, Philipp Zabel , Andrea della Porta , Phil Elwell , Jonathan Bell , Dave Stevenson , stable@vger.kernel.org References: <20250120130119.671119-1-svarbanov@suse.de> <20250120130119.671119-10-svarbanov@suse.de> <1abdd175-280a-442a-a27a-9bc01c0a04c0@broadcom.com> Content-Language: en-US From: Stanimir Varbanov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C7E151F383 X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[23]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linutronix.de,kernel.org,gmail.com,google.com,linux.com,pengutronix.de,suse.com,raspberrypi.com,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[dt]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: Hi, On 1/22/25 6:20 PM, Stanimir Varbanov wrote: > Hi Florian, > > On 1/21/25 8:32 PM, Florian Fainelli wrote: >> On 1/20/25 05:01, Stanimir Varbanov wrote: >>> A call to of_parse_phandle() increments refcount, of_node_put must be >>> called when done the work on it. Fix missing of_node_put() on the >>> msi_np device node by using scope based of_node_put() cleanups. >>> >>> Cc: stable@vger.kernel.org # v5.10+ >>> Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") >>> Signed-off-by: Stanimir Varbanov >>> --- >>> v4 -> v5: >>>   - New patch in the series. >>> >>>   drivers/pci/controller/pcie-brcmstb.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/ >>> controller/pcie-brcmstb.c >>> index 744fe1a4cf9c..546056f7f0d3 100644 >>> --- a/drivers/pci/controller/pcie-brcmstb.c >>> +++ b/drivers/pci/controller/pcie-brcmstb.c >>> @@ -1844,7 +1844,8 @@ static struct pci_ops brcm7425_pcie_ops = { >>>     static int brcm_pcie_probe(struct platform_device *pdev) >>>   { >>> -    struct device_node *np = pdev->dev.of_node, *msi_np; >>> +    struct device_node *msi_np __free(device_node) = NULL; >> >> In the interest of making this a straight back port to 5.10 that does >> not have all of the __free() goodies, I would just add the missing >> of_node_put() where necessary. > > Good point. Thank you. > >> >> Also, since this is a bug fix, you should probably make it appear >> earlier in the patch series, or even sent it as a separate fix entirely. > > OK, will send it as a standalone patch (as v2 with your comment addressed). Sent here [1], now separate from this series. ~Stan [1] https://lore.kernel.org/lkml/20250122222955.1752778-1-svarbanov@suse.de/T/