From: Joe Perches <joe@perches.com>
To: Andreas Brauchli <a.brauchli@elementarea.net>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: allow URL >80 chars
Date: Mon, 20 Nov 2017 22:02:57 -0800 [thread overview]
Message-ID: <1511244177.6989.24.camel@perches.com> (raw)
In-Reply-To: <1511181605.2384.2.camel@elementarea.net>
On Mon, 2017-11-20 at 13:40 +0100, Andreas Brauchli wrote:
> Allow URL to exceed the 80 char limit for improved interaction in
> adaption to ongoing but undocumented practice.
>
> $ git grep -E '://\S{77}.*' -- '*.[ch]'
>
> The patch checks that the URL is indeed on its own line in that it
> allows a maximal prefix of 3 characters to account for a URL after a
> comment (e.g. '// https://...')
I think this part is not necessary or that useful.
For instance, this style
/* some long url */
is pretty common.
> As per RFC3986 [1], the URL format allows for alphanum, +, - and .
> characters in the scheme before the separator :// as long as it starts
> with a letter (e.g. https, git, f.-+).
That seems right, thanks.
> Recognition of URIs without more context information is prone to false
> positives and thus currently left out of the heuristics.
OK.
next prev parent reply other threads:[~2017-11-21 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 12:40 Andreas Brauchli
2017-11-21 6:02 ` Joe Perches [this message]
2017-11-21 7:56 ` Andreas Brauchli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511244177.6989.24.camel@perches.com \
--to=joe@perches.com \
--cc=a.brauchli@elementarea.net \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome