From: Vasyl Gomonovych <gomonovych@gmail.com>
To: linux@armlinux.org.uk, alexander.h.duyck@intel.com,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com
Subject: [PATCH] ARM: dma-mapping:Fix ifnullfree.cocci warnings
Date: Wed, 22 Nov 2017 16:17:23 +0100 [thread overview]
Message-ID: <1511363843-26202-1-git-send-email-gomonovych@gmail.com> (raw)
NULL check before some freeing functions is not needed.
arch/arm/common/dmabounce.c:573:2-18: WARNING: NULL check before freeing functions like kfree
arch/arm/common/dmabounce.c:575:2-18: WARNING: NULL check before freeing functions like kfree
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
arch/arm/common/dmabounce.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 9a92de63426f..dcdd80c7a543 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -569,10 +569,8 @@ void dmabounce_unregister_dev(struct device *dev)
BUG();
}
- if (device_info->small.pool)
- dma_pool_destroy(device_info->small.pool);
- if (device_info->large.pool)
- dma_pool_destroy(device_info->large.pool);
+ dma_pool_destroy(device_info->small.pool);
+ dma_pool_destroy(device_info->large.pool);
#ifdef STATS
if (device_info->attr_res == 0)
--
1.9.1
reply other threads:[~2017-11-22 15:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511363843-26202-1-git-send-email-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®