From: Vasyl Gomonovych <gomonovych@gmail.com>
To: ralf@linux-mips.org, paul.burton@mips.com,
pure.logic@nexus-software.ie, akpm@linux-foundation.org,
bart.vanassche@sandisk.com, vladimir.murzin@arm.com,
l.stach@pengutronix.de, alexander.h.duyck@intel.com,
linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com
Subject: [PATCH] MIPS: dma-default: Use vma_pages helper
Date: Thu, 23 Nov 2017 00:16:12 +0100 [thread overview]
Message-ID: <1511392572-9254-1-git-send-email-gomonovych@gmail.com> (raw)
Use vma_pages function on vma object instead of explicit computation.
arch/mips/mm/dma-default.c:182:34-40: WARNING: Consider using vma_pages helper on vma
Generated by: scripts/coccinelle/api/vma_pages.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
arch/mips/mm/dma-default.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mm/dma-default.c b/arch/mips/mm/dma-default.c
index c01bd20d0208..bfd504c92719 100644
--- a/arch/mips/mm/dma-default.c
+++ b/arch/mips/mm/dma-default.c
@@ -179,7 +179,7 @@ static int mips_dma_mmap(struct device *dev, struct vm_area_struct *vma,
void *cpu_addr, dma_addr_t dma_addr, size_t size,
unsigned long attrs)
{
- unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ unsigned long user_count = vma_pages(vma);
unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT;
unsigned long addr = (unsigned long)cpu_addr;
unsigned long off = vma->vm_pgoff;
--
1.9.1
reply other threads:[~2017-11-22 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511392572-9254-1-git-send-email-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=bart.vanassche@sandisk.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=pure.logic@nexus-software.ie \
--cc=ralf@linux-mips.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®