From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbdKWCil (ORCPT ); Wed, 22 Nov 2017 21:38:41 -0500 Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:40586 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751742AbdKWCik (ORCPT ); Wed, 22 Nov 2017 21:38:40 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:152:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2693:2731:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3872:3873:3874:4321:4823:5007:10004:10400:10848:11232:11658:11914:12740:12895:13069:13095:13311:13357:13894:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: coat07_687f836494960 X-Filterd-Recvd-Size: 2304 Message-ID: <1511404716.2385.12.camel@perches.com> Subject: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format From: Joe Perches To: Chanwoo Choi , myungjoo.ham@samsung.com, Kyungmin Park Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 22 Nov 2017 18:38:36 -0800 In-Reply-To: <5A1633F2.6000103@samsung.com> References: <1511347280.6989.81.camel@perches.com> <7d659960e45f66894126fba9e2d54cf25ae1185b.1510845910.git.joe@perches.com> <5A150792.6050104@samsung.com> <20171123012100epcms1p13f78950557de06dbbd65996c8b0645ee@epcms1p1> <5A162835.5050806@samsung.com> <1511402826.2385.3.camel@perches.com> <5A162E8A.3040207@samsung.com> <1511403518.2385.8.camel@perches.com> <5A163119.1050500@samsung.com> <1511404163.2385.11.camel@perches.com> <5A1633F2.6000103@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-23 at 11:35 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 11:29, Joe Perches wrote: > > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: > > > On 2017년 11월 23일 11:18, Joe Perches wrote: > > > > never break user-visible strings such as > > > > printk messages, because that breaks the ability to grep for them > > > > > > So, I suggested "Or, we better to modify the error message within 80 char.". > > > > Run checkpatch on your suggestion. > > You will get a "split_string" warning. > > I knew about this. I don't like to hurt the readability > in order to fix the warning with the improper way. > > If you want to fix it, I suggested that you better to modify > the error message within 80 char. Or I prefer the Myungjoo's opinion. Again, I don't really care how it's fixed, but the 3 tabs in the middle of the message are stupid. Please fix it.