From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbdKWJcQ (ORCPT ); Thu, 23 Nov 2017 04:32:16 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39365 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbdKWJcP (ORCPT ); Thu, 23 Nov 2017 04:32:15 -0500 Message-ID: <1511429504.7685.12.camel@pengutronix.de> Subject: Re: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR()) From: Philipp Zabel To: Vasyl Gomonovych , ck.hu@mediatek.com, airlied@linux.ie, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 23 Nov 2017 10:31:44 +0100 In-Reply-To: <1511303493-14897-1-git-send-email-gomonovych@gmail.com> References: <1511303493-14897-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote: > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem > Generated by: scripts/coccinelle/api/err_cast.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > index f595ac816b55..5766b42fc174 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, > mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size); > > if (IS_ERR(mtk_gem)) > - return ERR_PTR(PTR_ERR(mtk_gem)); > + return ERR_CAST(mtk_gem)); > > expected = sg_dma_address(sg->sgl); > for_each_sg(sg->sgl, s, sg->nents, i) { Acked-by: Philipp Zabel regards Philipp