From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbdKWNFU (ORCPT ); Thu, 23 Nov 2017 08:05:20 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:40640 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdKWNFS (ORCPT ); Thu, 23 Nov 2017 08:05:18 -0500 Message-ID: <1511442310.14687.58.camel@decadent.org.uk> Subject: Re: [PATCH 3.16 105/133] mm/vmstat.c: fix wrong comment From: Ben Hutchings To: Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: akpm@linux-foundation.org, SeongJae Park , Linus Torvalds , Michal Hocko Date: Thu, 23 Nov 2017 13:05:10 +0000 In-Reply-To: <716103c8-97cb-e891-b24e-c6dbd80f065d@suse.cz> References: <716103c8-97cb-e891-b24e-c6dbd80f065d@suse.cz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-n/SJIahAz6EbztmtUjQq" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 82.29.14.3 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-n/SJIahAz6EbztmtUjQq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-11-22 at 08:41 +0100, Vlastimil Babka wrote: > On 11/22/2017 02:58 AM, Ben Hutchings wrote: > > 3.16.51-rc1 review patch. If anyone has any objections, please let me = know. >=20 > I don't really care much in the end, but is "fix wrong comment" really a > stable patch material these days? :) It had a Fixes: field and it clearly won't do any harm. Still, none of the other stable branches has it so I'll drop it. Ben. > > ------------------ > >=20 > > From: SeongJae Park > >=20 > > commit f113e64121ba9f4791332248b315d9f57ee33a6b upstream. > >=20 > > Comment for pagetypeinfo_showblockcount() is mistakenly duplicated from > > pagetypeinfo_show_free()'s comment. This commit fixes it. > >=20 > > Link: http://lkml.kernel.org/r/20170809185816.11244-1-sj38.park@gmail.c= om > > Fixes: 467c996c1e19 ("Print out statistics in relation to fragmentation= avoidance to /proc/pagetypeinfo") > > Signed-off-by: SeongJae Park > > Cc: Michal Hocko > > Cc: Vlastimil Babka > > Signed-off-by: Andrew Morton > > Signed-off-by: Linus Torvalds > > Signed-off-by: Ben Hutchings > > --- > > mm/vmstat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -975,7 +975,7 @@ static void pagetypeinfo_showblockcount_ > > seq_putc(m, '\n'); > > } > > =20 > > -/* Print out the free pages at each order for each migratetype */ > > +/* Print out the number of pageblocks for each migratetype */ > > static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > > { > > int mtype; > >=20 >=20 >=20 --=20 Ben Hutchings When in doubt, use brute force. - Ken Thompson --=-n/SJIahAz6EbztmtUjQq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAloWx4YACgkQ57/I7JWG EQmGuRAAi5qtBip/BqxRDocA9yVvbC8qDCLANI6/0qvNpov+E/sXIYwVe0uH9Z8X Srr32DGtRYF9eitaD54eP7sq5F9/pq4Tiapv5Dw4duL5cI0azkIk63RViyirJCsX czjPs3pu35OlM92LZh8gSrIJDuWLN/Rs7iRRB9EL2vFnoWwU6OEgfbrY93rxu5O0 6yBguckTo1O0h0ZGCI/yZYXwODz4yEtlcNsKYu2sN7uzWCMgO5cthKcGGxDOUzbH pO2eWWXCYNVWuj9aKIQMRpUhFuf/SfZJ6z7PIUh3IDmRe2v3gN7ITbgcY+LNPXbK 2ZjxaF8cQ6YP0c1NS1G8Anss5folqchjdlKDFTeOhQbwQNkTP6dlQGhS7jr36VMe AJfNEwRpJng1Fx703LpelK2WzQ8zxvHe7suwnQV6XUjyBCaRV2iRhSX1hqPFG39R AIwSwk74YIQBn/rfDb0R9qb6IfAtYKvkrLqk+EE18DfKHHW3vFxF/VUT0PoPCziV y2iD9xK8GIO+HRzunODUf8wTFtJR2vP6AwN9CDhocGLUmaZz+V/1eWYOybJuP4vi 7nIjj3MIpu4oGDqnWU+hfItm9MgvJCOO4akYcg2jWc8OimtbK85HKPeDZmcT4+ct 0Ame+DhdzncMgfVkzoh0TYzhedpQPWpB1b1CL/lVYIDjQNBOifE= =p5wF -----END PGP SIGNATURE----- --=-n/SJIahAz6EbztmtUjQq--