From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbcEYIug (ORCPT ); Wed, 25 May 2016 04:50:36 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59628 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871AbcEYIu3 (ORCPT ); Wed, 25 May 2016 04:50:29 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, Linus Walleij , Rob Herring , thomas.ab@samsung.com, kgene@kernel.org, Grant Likely Subject: Re: [PATCH v6 1/2] soc: samsung: add exynos chipid driver support Date: Wed, 25 May 2016 10:49:53 +0200 Message-ID: <15114439.HIyt1ChUT2@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464163104-8163-2-git-send-email-pankaj.dubey@samsung.com> References: <1464163104-8163-1-git-send-email-pankaj.dubey@samsung.com> <1464163104-8163-2-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BlQX0leOAN8WUrK2g9Pl8XWFmE7lxjLTMOdM/XLF7meuBLuG+X9 H3zt7Ka2Z0KNAB79DEMvq8CIg0Al7VskMiRYpd/HKCKcfgzbbq23ev1ZaYb3k3WYDwgBsCc TCkxRLz8/PePJJvXOh3EZFxPgDFDnfNWB1jHX3BN1PkLze6rh4j/4zxq33R+faOGJ2KdNlh Kevzc6ko6KfgCYYB0MrjQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:x8VCPu/v50s=:7tp2MuQtyXR/C4dzDuORvm n+pvnqMv/qrmfkEvswD3njKfKjPJSeJOJpUih3DK0JzAEQ/xxgThYGj7HP7fQrX5IJHRbD38j T7Hqgy43viEUGtsTIkVEtxuHTx9mN1mtmOJ4cU477vtg5sOrnx9ObEQPdweIGZAab1AxSCevE IR2GIcm6SlMivHwaLd2rAw6wBwrlNH3oBGMHOvH2RPxML94GPbW8QkW9z4NR1IiPVTBEXuwij PtP3jceygMBz/5pOl7AkiczyY9AH/ErfrkeRToR2TQJKlNL7PDsDN9y6w7G2g2oAjBrkRY5UC kgKxKUAJ2/7ux0w35PFdN+q0Q1ZQWb3yP0howlj2T6/X6tIs3Gvz6/Nx5uHv/jpaSbG3mTnwA o+gkm4DtK1+kedN4EAw+AlmMcL+Ak9Zqjx1CMDHuKKZoaEGzHFtbBsQZtxvbQ5iKJfEJ/v4/w +TVjYRkhQvWM4+veKrJrF3Ouzrk3epz+fZEEVmoBuIB9cJNWMtW0g+6eOSc1EWQoBe4NOeYV9 0FxexweOuf/2WLRFCtOLVz3EGyOn+VtT44yBfFVC56meQnr/XoNcvLufbk4NupSAY1pb0aPOw 9QPYdt/1mqvlEFe43f2yXKnHw3T7ekO7gSwjoNV0auHhpzej5je8XvUmpc43GM+AfJebCxaR4 kOK4OH0t4X+FBSYseQx1ium12r7cE4849WSwsqPnr9sDNlJjgTUxMLOKd/EZ8PEK6o6ptADzW k8vDoEMPngSk2Bzt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, May 25, 2016 1:28:23 PM CEST Pankaj Dubey wrote: > Exynos SoCs have Chipid, for identification of product IDs > and SoC revisions. This patch intends to provide initialization > code for all these functionalities, at the same time it provides some > sysfs entries for accessing these information to user-space. > > This driver uses existing binding for exynos-chipid. > > CC: Grant Likely > CC: Rob Herring > CC: Linus Walleij > Signed-off-by: Pankaj Dubey > --- > drivers/soc/samsung/Kconfig | 5 + > drivers/soc/samsung/Makefile | 1 + > drivers/soc/samsung/exynos-chipid.c | 172 +++++++++++++++++++++++++++++++++ > include/linux/soc/samsung/exynos-soc.h | 51 ++++++++++ > I don't like how this exposes the internals of the samsung SoC in a global header file, after we spent a considerable amount of work on keeping it confined to arch/arm/{mach-exynos,mach-s3c64xx,plat-samsung}. Please remove the external interface of the driver, in particular the global data structure. We keep coming back to this for a lot of platforms, and I still think we should have an architecture-independent way of matching platforms to struct soc_device, using an exported function from drivers/base/soc.c that uses glob_match() to compare a platform string against the running system. Arnd