From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbdKWPzs (ORCPT ); Thu, 23 Nov 2017 10:55:48 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:32771 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbdKWPzm (ORCPT ); Thu, 23 Nov 2017 10:55:42 -0500 X-Google-Smtp-Source: AGs4zMaJJsYwxTdyP+QB5duuUYHIRopZOP5cKhXj20rBIEZ30lVDpTDb/+UAzfYNmDk+af9GJJXy5A== From: Arvind Yadav To: myungjoo.ham@samsung.com, cw00.choi@samsung.com, wens@csie.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/2] extcon: adc-jack: Fix platform_get_irq's error checking Date: Thu, 23 Nov 2017 21:25:29 +0530 Message-Id: <1511452530-16858-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/extcon/extcon-adc-jack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index 3877d86..1802635 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers/extcon/extcon-adc-jack.c @@ -144,7 +144,7 @@ static int adc_jack_probe(struct platform_device *pdev) return err; data->irq = platform_get_irq(pdev, 0); - if (!data->irq) { + if (data->irq < 0) { dev_err(&pdev->dev, "platform_get_irq failed\n"); return -ENODEV; } -- 2.7.4