From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbdKWP4C (ORCPT ); Thu, 23 Nov 2017 10:56:02 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35435 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbdKWPzp (ORCPT ); Thu, 23 Nov 2017 10:55:45 -0500 X-Google-Smtp-Source: AGs4zMYgz4zbzLpt4V84icirFWeKEIizTtdM8c3+RA8yUIoYCOMYB4VcrtTuCKH7ukG6L37W/HKj+A== From: Arvind Yadav To: myungjoo.ham@samsung.com, cw00.choi@samsung.com, wens@csie.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq Date: Thu, 23 Nov 2017 21:25:30 +0530 Message-Id: <1511452530-16858-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1511452530-16858-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/extcon/extcon-axp288.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c index 981fba5..e16a783 100644 --- a/drivers/extcon/extcon-axp288.c +++ b/drivers/extcon/extcon-axp288.c @@ -301,6 +301,9 @@ static int axp288_extcon_probe(struct platform_device *pdev) for (i = 0; i < EXTCON_IRQ_END; i++) { pirq = platform_get_irq(pdev, i); + if (pirq < 0) + return pirq; + info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); if (info->irq[i] < 0) { dev_err(&pdev->dev, -- 2.7.4