From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143AbdKWQAz (ORCPT ); Thu, 23 Nov 2017 11:00:55 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:46870 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbdKWQAy (ORCPT ); Thu, 23 Nov 2017 11:00:54 -0500 X-Google-Smtp-Source: AGs4zMZgRoHQjS18Es2NARTzQBFRZnlZGBQx8CiIb39FyYx1CKBNCkvPrO7JSsZcrq27UjhzDTWxOw== From: Vasyl Gomonovych To: keescook@chromium.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com Subject: [PATCH] lkdtm: Missing kmalloc check Date: Thu, 23 Nov 2017 17:00:42 +0100 Message-Id: <1511452842-10680-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Handling a possible memory allocation failure. Signed-off-by: Vasyl Gomonovych --- drivers/misc/lkdtm_heap.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/lkdtm_heap.c b/drivers/misc/lkdtm_heap.c index f5494a6d4be5..65026d7de130 100644 --- a/drivers/misc/lkdtm_heap.c +++ b/drivers/misc/lkdtm_heap.c @@ -16,6 +16,8 @@ void lkdtm_OVERWRITE_ALLOCATION(void) { size_t len = 1020; u32 *data = kmalloc(len, GFP_KERNEL); + if (!data) + return; data[1024 / sizeof(u32)] = 0x12345678; kfree(data); @@ -33,6 +35,8 @@ void lkdtm_WRITE_AFTER_FREE(void) size_t offset = (len / sizeof(*base)) / 2; base = kmalloc(len, GFP_KERNEL); + if (!base) + return; pr_info("Allocated memory %p-%p\n", base, &base[offset * 2]); pr_info("Attempting bad write to freed memory at %p\n", &base[offset]); -- 1.9.1