From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbdKXDL2 (ORCPT ); Thu, 23 Nov 2017 22:11:28 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33081 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdKXDL0 (ORCPT ); Thu, 23 Nov 2017 22:11:26 -0500 X-Google-Smtp-Source: AGs4zMZLAPSQ4lQzcA9+33lDNOkWzZAqhjpmrKcORuao3IMh3NSVI/YL1Zp+CzLgs581pfnLc3D8dQ== Subject: Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable From: Ching Huang To: Dan Carpenter Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jthumshirn@suse.de, hare@suse.de, hch@infradead.org In-Reply-To: <20171123114336.bnekgwbrdbx7kvnn@mwanda> References: <1511400674.9832.23.camel@Centos6.3-64> <20171123114336.bnekgwbrdbx7kvnn@mwanda> Content-Type: text/plain; charset="UTF-8" Date: Fri, 24 Nov 2017 03:11:25 +0800 Message-ID: <1511464285.4370.2.camel@Centos6.3-64> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-37.el6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-23 at 14:43 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > > unsigned long flags; > > int nvec, i; > > > > + if (msix_enable == 0) > > + goto msi_int0; > > I feel like this goto is not very beautiful, but I can't actually apply > this patch? Which tree is this written against? I'm using linux-next. > This patch is apply to https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/tree/?h=4.16/scsi-queue > regards, > dan carpenter > >