From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbdKYGj6 (ORCPT ); Sat, 25 Nov 2017 01:39:58 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:44384 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbdKYGjw (ORCPT ); Sat, 25 Nov 2017 01:39:52 -0500 X-Google-Smtp-Source: AGs4zMbP+M6i+RP+bvcRNX9QLH7WajaxhqIvb9COtpywJnZCj2IhH/w/dGDNc0S9j31q3VYasywrUA== From: Arvind Yadav To: gilad@benyossef.com, gregkh@linuxfoundation.org, oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, paulmck@linux.vnet.ibm.com, vitaly_fertman@xyratex.com, yawei.niu@intel.com Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org Subject: [PATCH 1/4] staging: ccree: Remove a attribute group from a kobject Date: Sat, 25 Nov 2017 12:09:28 +0530 Message-Id: <1511591971-8615-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511591971-8615-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1511591971-8615-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org All attribute group created during sys_init_dir() should be removed in sys_free_dir() Signed-off-by: Arvind Yadav --- drivers/staging/ccree/ssi_sysfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c index 5d39f15..14a3f32 100644 --- a/drivers/staging/ccree/ssi_sysfs.c +++ b/drivers/staging/ccree/ssi_sysfs.c @@ -145,8 +145,11 @@ static void sys_free_dir(struct sys_dir *sys_dir) kfree(sys_dir->sys_dir_attr_list); - if (sys_dir->sys_dir_kobj) + if (sys_dir->sys_dir_kobj) { + sysfs_remove_group(sys_dir->sys_dir_kobj, + &sys_dir->sys_dir_attr_group); kobject_put(sys_dir->sys_dir_kobj); + } } int ssi_sysfs_init(struct kobject *sys_dev_obj, struct ssi_drvdata *drvdata) -- 2.7.4