From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdKYLC3 (ORCPT ); Sat, 25 Nov 2017 06:02:29 -0500 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:35047 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750935AbdKYLC2 (ORCPT ); Sat, 25 Nov 2017 06:02:28 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2902:3138:3139:3140:3141:3142:3351:3622:3865:3872:4321:5007:10004:10400:10848:11026:11658:11914:12048:12296:12438:12679:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: geese89_6c884d4b98221 X-Filterd-Recvd-Size: 1488 Message-ID: <1511607744.2503.1.camel@perches.com> Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error From: Joe Perches To: Arvind Yadav , b.zolnierkie@samsung.com, tj@kernel.org, sergei.shtylyov@cogentembedded.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Date: Sat, 25 Nov 2017 03:02:24 -0800 In-Reply-To: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> References: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] > diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] > @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed > */ > static struct pdc2027x_pio_timing { > u8 value0, value1, value2; > -} pdc2027x_pio_timing_tbl [] = { > +} pdc2027x_pio_timing_tbl[] = { > { 0xfb, 0x2b, 0xac }, /* PIO mode 0 */ > { 0x46, 0x29, 0xa4 }, /* PIO mode 1 */ > { 0x23, 0x26, 0x64 }, /* PIO mode 2 */ trivia: It seems all the _timing_tbl structs should be const