From: Joe Perches <joe@perches.com>
To: Jeremy Lacomis <j.lacomis@gmail.com>,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750b: Fix coding style issues in sm750_accel.c
Date: Sat, 25 Nov 2017 13:38:41 -0800 [thread overview]
Message-ID: <1511645921.2503.18.camel@perches.com> (raw)
In-Reply-To: <20171125182636.15245-2-j.lacomis@gmail.com>
On Sat, 2017-11-25 at 13:26 -0500, Jeremy Lacomis wrote:
> This is a patch to sm750_accel.c that fixes 80-character line length
> warnings found by checkpatch.pl. It also fixes some grammatical errors
> in comments and moves parameter-specific comments from inline to before
> the function.
[]
> + * Notes on these parameters:
> + * sBase: Address of the source offset in the frame buffer
> + * sPitch: Pitch value of the source surface in BYTE
> + * sx, sy: Starting coordinate of the source surface
> + * dBase: Address of the destination offset in the frame buffer
> + * dPitch: Pitch value of the destination surface in BYTE
> + * Bpp: Color depth of the destination surface
> + * dx, dy: Starting coordinate of the destination surface
> + * width, height: Dimensions of the rectangle in pixels
> + * rop2: ROP value
Use kernel-doc format instead.
next prev parent reply other threads:[~2017-11-25 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 18:26 [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h Jeremy Lacomis
2017-11-25 18:26 ` [PATCH 2/2] staging: sm750b: Fix coding style issues in sm750_accel.c Jeremy Lacomis
2017-11-25 21:38 ` Joe Perches [this message]
2017-11-27 9:46 ` [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h Dan Carpenter
2017-11-27 10:45 ` Geert Uytterhoeven
2017-11-27 14:37 ` Jeremy Lacomis
2017-11-28 12:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511645921.2503.18.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.lacomis@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome