From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbdKYWgc (ORCPT ); Sat, 25 Nov 2017 17:36:32 -0500 Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:39076 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751648AbdKYWgb (ORCPT ); Sat, 25 Nov 2017 17:36:31 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3871:3872:3874:4321:5007:7514:7903:8957:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12555:12683:12740:12760:12895:13439:14096:14097:14110:14181:14659:14721:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: glass44_389edc199c526 X-Filterd-Recvd-Size: 2936 Message-ID: <1511649387.20482.5.camel@perches.com> Subject: Re: [PATCH] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c From: Joe Perches To: Jeremy Lacomis , sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 25 Nov 2017 14:36:27 -0800 In-Reply-To: <20171125175937.10428-1-j.lacomis@gmail.com> References: <20171125175937.10428-1-j.lacomis@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-11-25 at 12:59 -0500, Jeremy Lacomis wrote: > This is a patch to the ddk750_sii164.c file that fixes line length warnings > found by the checkpatch.pl script > > Signed-off-by: Jeremy Lacomis > --- > drivers/staging/sm750fb/ddk750_sii164.c | 39 +++++++++++++++++++-------------- > 1 file changed, 23 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index c787a74c4f9c..d081ecbb3e3d 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -39,8 +39,10 @@ unsigned short sii164GetVendorID(void) > { > unsigned short vendorID; > > - vendorID = ((unsigned short) i2cReadReg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | > - (unsigned short) i2cReadReg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_LOW); > + vendorID = ((unsigned short) i2cReadReg(SII164_I2C_ADDRESS, > + SII164_VENDOR_ID_HIGH) << 8) | > + (unsigned short) i2cReadReg(SII164_I2C_ADDRESS, > + SII164_VENDOR_ID_LOW); > > return vendorID; > } > @@ -56,15 +58,20 @@ unsigned short sii164GetDeviceID(void) > { > unsigned short deviceID; > > - deviceID = ((unsigned short) i2cReadReg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_HIGH) << 8) | > - (unsigned short) i2cReadReg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_LOW); > + deviceID = ((unsigned short) i2cReadReg(SII164_I2C_ADDRESS, > + SII164_DEVICE_ID_HIGH) << 8) | > + (unsigned short) i2cReadReg(SII164_I2C_ADDRESS, > + SII164_DEVICE_ID_LOW); > > return deviceID; > } i2cReadReg is always used with SII154_I2C_ADDRESS. Perhaps it'd be better to redefine i2cReadReg to something else. i2cReadReg also returns an unsigned char so this cast isn't particularly sensible. Perhaps something like: #define sii164_i2c_read_reg(reg) i2cReadReg(SII164_I2C_ADDRESS, reg) device_id = sii164_i2c_read_reg(SII164_DEVICE_ID_HIGH) << 8 | sii164_i2c_read_reg(SII164_DEVICE_ID_LOW);