mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: engler@csl.Stanford.EDU (Dawson Engler),
	linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] free bugs in 2.4.4 and 2.4.4-ac8
Date: Thu, 24 May 2001 16:17:55 -0700 (PDT)	[thread overview]
Message-ID: <15117.38563.622597.223968@pizda.ninka.net> (raw)
In-Reply-To: <E1533qI-0005jT-00@the-village.bc.nu>
In-Reply-To: <200105242104.OAA29654@csl.Stanford.EDU> <E1533qI-0005jT-00@the-village.bc.nu>


Alan Cox writes:
 > > [BUG]  seems possible --- or is some precondition guarenteed?
 > > /u2/engler/mc/oses/linux/2.4.4-ac8/net/ipv6/udp.c:438:udpv6_recvmsg: ERROR:FREE:453:438: WARN: Use-after-free of "skb"! set by 'kfree_skb':453
 > 
 > Looks right. Left for DaveM

It's wrong, in the MSG_PEEK case skb->users is incremented by
skb_recv_datagram, so to truly get rid of it we do indeed need to
unlink it from the receive_queue then free it twice :-)

Later,
David S. Miller
davem@redhat.com

  parent reply	other threads:[~2001-05-24 23:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-24 21:04 Dawson Engler
2001-05-24 21:17 ` Alexander Viro
2001-05-24 22:01 ` Justin Carlson
2001-05-24 22:44 ` Alan Cox
2001-05-24 22:55   ` Justin Carlson
2001-05-24 23:16     ` Alan Cox
2001-05-25 15:21   ` Jeff Hartmann
2001-05-24 23:17 ` David S. Miller [this message]
2001-05-25  5:19 ` Greg KH
2001-05-25 17:59 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15117.38563.622597.223968@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=engler@csl.Stanford.EDU \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mc@cs.Stanford.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®