From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdK0LdV (ORCPT ); Mon, 27 Nov 2017 06:33:21 -0500 Received: from s3.sipsolutions.net ([144.76.63.242]:36202 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbdK0LdU (ORCPT ); Mon, 27 Nov 2017 06:33:20 -0500 Message-ID: <1511782395.5456.5.camel@sipsolutions.net> Subject: Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls From: Johannes Berg To: Ishraq Ibne Ashraf , Dan Carpenter Cc: gregkh@linuxfoundation.org, himanshujha199640@gmail.com, goudapatilk@gmail.com, insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 27 Nov 2017 12:33:15 +0100 In-Reply-To: (sfid-20171126_014603_702833_4D221C77) References: <1511400546-10875-1-git-send-email-ishraq.i.ashraf@gmail.com> <1511571155-12101-1-git-send-email-ishraq.i.ashraf@gmail.com> <20171125044014.lfdwsrfgl4dz725d@mwanda> (sfid-20171126_014603_702833_4D221C77) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, So I removed those call-through place because private wext operations are a really bad idea and should just die. We don't want drivers to require specially patched hostapd versions to work right, like here. I suppose in staging you might want to work around that like here, but that really means you see no future in mainline for this code, or otherwise you should fix it the proper way. johannes