From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753093AbdK0XKo (ORCPT ); Mon, 27 Nov 2017 18:10:44 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35890 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbdK0XKn (ORCPT ); Mon, 27 Nov 2017 18:10:43 -0500 X-Google-Smtp-Source: AGs4zMYnVqXDoyp4g5aXT7hrlVDI/v6iVlK9i/5b78surpafN/dwKnub0C/ZM9XnlSODrsWAiUxw+A== From: Vasyl Gomonovych To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com Subject: [PATCH] sysfs: Use PTR_ERR_OR_ZERO() Date: Tue, 28 Nov 2017 00:10:32 +0100 Message-Id: <1511824232-13428-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix ptr_ret.cocci warnings: fs/sysfs/group.c:409:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych --- fs/sysfs/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index ac2de0ed69ad..3f8efe8f387b 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -406,6 +406,6 @@ int __compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, kernfs_put(entry); kernfs_put(target); - return IS_ERR(link) ? PTR_ERR(link) : 0; + return PTR_ERR_OR_ZERO(link); } EXPORT_SYMBOL_GPL(__compat_only_sysfs_link_entry_to_kobj); -- 1.9.1