From: Vasyl Gomonovych <gomonovych@gmail.com>
To: acme@redhat.com, joe@ovn.org, wangnan0@huawei.com, ast@fb.com,
davem@davemloft.net, john.fastabend@gmail.com
Cc: gomonovych@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] tools lib bpf: Use PTR_ERR_OR_ZERO()
Date: Tue, 28 Nov 2017 00:11:43 +0100 [thread overview]
Message-ID: <1511824303-15856-1-git-send-email-gomonovych@gmail.com> (raw)
Fix ptr_ret.cocci warnings:
tools/lib/bpf/libbpf.c:1744:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
tools/lib/bpf/libbpf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 35f6dfcdc565..c0894ef65631 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1741,9 +1741,7 @@ struct bpf_map *
long libbpf_get_error(const void *ptr)
{
- if (IS_ERR(ptr))
- return PTR_ERR(ptr);
- return 0;
+ return PTR_ERR_OR_ZERO(ptr);
}
int bpf_prog_load(const char *file, enum bpf_prog_type type,
--
1.9.1
reply other threads:[~2017-11-27 23:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511824303-15856-1-git-send-email-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=acme@redhat.com \
--cc=ast@fb.com \
--cc=davem@davemloft.net \
--cc=joe@ovn.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®