From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbdK0Xlw (ORCPT ); Mon, 27 Nov 2017 18:41:52 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53823 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbdK0Xld (ORCPT ); Mon, 27 Nov 2017 18:41:33 -0500 X-ME-Sender: From: "Tobin C. Harding" To: Linus Torvalds Cc: "Tobin C. Harding" , "Jason A. Donenfeld" , "Theodore Ts'o" , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein , Daniel Micay , Djalal Harouni , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: [PATCH 5/5] vfio_pci: use %px to print token identifier Date: Tue, 28 Nov 2017 10:40:58 +1100 Message-Id: <1511826058-2563-6-git-send-email-me@tobin.cc> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511826058-2563-1-git-send-email-me@tobin.cc> References: <1511826058-2563-1-git-send-email-me@tobin.cc> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently token address is printed using %p. This exposes the address of the token in dmesg and potentially leaks sensitive information to userspace. In this instance the address is being used as a unique identifier for the token, we can use the newly defined printk specifier %px for exactly this purpose. Use the new %px specifier to print a unique identifier for the token. Signed-off-by: Tobin C. Harding --- drivers/vfio/pci/vfio_pci_intrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index 1c46045b0e7f..73d3ae8b5784 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -346,7 +346,7 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev, ret = irq_bypass_register_producer(&vdev->ctx[vector].producer); if (unlikely(ret)) dev_info(&pdev->dev, - "irq bypass producer (token %p) registration fails: %d\n", + "irq bypass producer (token %px) registration fails: %d\n", vdev->ctx[vector].producer.token, ret); vdev->ctx[vector].trigger = trigger; -- 2.7.4