From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751373AbdK1Fyd (ORCPT ); Tue, 28 Nov 2017 00:54:33 -0500 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:44277 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750711AbdK1Fyb (ORCPT ); Tue, 28 Nov 2017 00:54:31 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3870:4321:5007:10004:10400:10848:11658:11914:12048:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: apple16_444b05c824b29 X-Filterd-Recvd-Size: 1245 Message-ID: <1511848467.32426.100.camel@perches.com> Subject: Re: [PATCH] atm: eni: fix several indentation issues From: Joe Perches To: Colin King , Chas Williams <3chas3@gmail.com>, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 Nov 2017 21:54:27 -0800 In-Reply-To: <20171127131510.10500-1-colin.king@canonical.com> References: <20171127131510.10500-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-11-27 at 13:15 +0000, Colin King wrote: > drivers/atm/eni.c Aren't all those ++ variables unused? They seem to be emitted in an #if 0 printk(...) #endif Maybe these should be removed or changed to something like: #if 0 #define DEBUG_INCR(var) do { (var)++ } while (0) #else #define DEBUG_INCR(var) do {} while (0) #endif ... DEBUG_INCR(rx_enqueued);