From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753351AbdK1LFt convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 06:05:49 -0500
Received: from mout.gmx.net ([212.227.17.20]:59733 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755000AbdK1Kt4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 05:49:56 -0500
Message-ID: <1511866151.8472.51.camel@gmx.de>
Subject: Re: [PATCH RFC 1/2] sched: Minimize the idle cpu selection race
 window.
From: Mike Galbraith <efault@gmx.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Atish Patra <atish.patra@oracle.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Joel Fernandes <joelaf@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Brendan Jackman <brendan.jackman@arm.com>, Josef Bacik <jbacik@fb.com>,
        Ingo Molnar <mingo@redhat.com>
Date: Tue, 28 Nov 2017 11:49:11 +0100
In-Reply-To: <20171128093422.5hmrkonj3z6twy2y@pc636>
References: <1509427662-25114-1-git-send-email-atish.patra@oracle.com>
         <1509427662-25114-2-git-send-email-atish.patra@oracle.com>
         <20171031082009.rxxa57goto6q5xld@hirez.programming.kicks-ass.net>
         <CAJWu+ooYjFK3+cLnzKgmchOL_bwdYjvHkOL0de=SixVT_CLy=Q@mail.gmail.com>
         <49e98b00-80c7-b3a4-30fd-bccb382d002b@oracle.com>
         <20171123105247.wcl2fiypge2pvile@pc636> <1511442781.6505.26.camel@gmx.de>
         <20171124102636.zqqjqa3sru7ebh4k@pc636> <1511549190.8029.233.camel@gmx.de>
         <20171128093422.5hmrkonj3z6twy2y@pc636>
Content-Type: text/plain; charset="ISO-8859-15"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
X-Provags-ID: V03:K0:wKaAkfMeRsqLxqZk84qX2ovtdCu2qoozVP5df8FQCfGWIPjbtFl
 EFwMsMgD1iOx3uqFDw3wmaIFb9i7PAZp+DT1XrwT6nb4rxRXi7wQFhvMJb7T5wDIeDmj7VU
 2g05AW5jjaUc75xy8QALla2NWtOwdHpLzmj/y2ce7eTm7d/ksvYEIKW2Nq2WFDa4EZL0Pep
 F7AN+oOp5ig3rfdTM+dwg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:FbA6oqLWSMw=:TdzccwWr+s8UakA2UqOiQD
 aHtNVl4JALpgX1hl2FZKHPVPg6eHHvWT0mJbMsd1wNxiVTPXvYxCXfhK9dx3MShCkZsRgTUcl
 +q/Wwz70W5l+5G0XtUBYpsD/+IkhI8KXp9V+wRB2GSbo8ZhssNeitON0fKMPWWKqBytuffhxL
 p8KCPEJcrU2VXxNpZBdx8sUVLYkWhp5Ujjx+Huoi0DSr1hXFGZ8fN/CQqEkgsIKue3pbB9eSs
 L0dVYgILnfTco8sALnGOMgEK7l5iPv8VhMh+DgNP2dqsVcYGMHfmR+2n5XnM8+0dMHAcZ9TMO
 96dRWZ+TUGb2iED/g/smImfZnkCJmrgfStI2ytx2EvbldqtSZe7gI/oGJDULxyUaZfVi/wigd
 1MwnuhSJ3BDJMJlJEeW/gGpls27Ebd5lykRGl0by/acjW/JhefKbD+14l+DwjqXdwzGeKpgeV
 3zuV9IT7Ltfw+ziqWxP8NO8DtFh5weSSU+37lwdfmYDcfLtLcjb5uZf1aol8B+RiLcKHTrOQu
 cTyqKa9jUfCeiiDMijsRF2fEsRORGVZpHINGV/LZfEm1xt0I+Z1se89Xqraq/sj0lTK7QTOOy
 9x1SM7nfh9iG7+haYRP8pjyN3PNJ39Q0RUqylpAp1FL6ETR1QyhID21NlacrJyMwcVi/8xd3f
 taemfh79P80M+J5TH91MTTPypd1CvWtN9wTtmiE8iMsPG9DsxkE/KrVh01WTT9owsZnZoEzu4
 /BjEwnsNgB3dA7HbqBGECiYL+/+cHxyenRMOr0MizITNlvrKUFtwrc9tBJLdlmtSYmBpdPvqX
 OA/Qtai43NX4FJ3ZJVeU655bf8bkd6vCrpDbgltgKa8m38KkmE=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-11-28 at 10:34 +0100, Uladzislau Rezki wrote:
> On Fri, Nov 24, 2017 at 07:46:30PM +0100, Mike Galbraith wrote:
> 
> > My view is you're barking up the wrong tree: you're making the idle
> > data SIS is using more accurate, but I question the benefit.  That it
> > makes an imperfect placement decision occasionally due to raciness is
> > nearly meaningless compared to the cost of frequent bounce.

> Before sitting down and start testing, i just illustrated how we can
> apply claim_wake_up to ilb asking community a specific view on it:
> drawbacks, pros/cons, proposals etc.

Even if you make the thing atomic, what is ILB supposed to do, look
over its shoulder every step of the way and sh*t it's pants if somebody
touches claim_wake_up as it's about to or just after it did something?

If you intend to make all of LB race free, good luck.

	-Mike