From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbdK1PNk (ORCPT ); Tue, 28 Nov 2017 10:13:40 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:40086 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbdK1PNi (ORCPT ); Tue, 28 Nov 2017 10:13:38 -0500 X-Google-Smtp-Source: AGs4zMasjNE0j5R/KjHRu6P4mjYa0+19iwLRGG+MZTP573p/F7MPR+qiGs3LLTpFCbvrCPEUxho81Q== From: Vasyl Gomonovych To: linux-kernel@vger.kernel.org Cc: gomonovych@gmail.com Subject: [PATCH] DCA: Use PTR_ERR_OR_ZERO() Date: Tue, 28 Nov 2017 16:13:24 +0100 Message-Id: <1511882004-24515-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix ptr_ret.cocci warnings: drivers/dca/dca-sysfs.c:43:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych --- drivers/dca/dca-sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c index 126cf295b198..b2f8be048089 100644 --- a/drivers/dca/dca-sysfs.c +++ b/drivers/dca/dca-sysfs.c @@ -40,9 +40,7 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot) cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1), NULL, "requester%d", req_count++); - if (IS_ERR(cd)) - return PTR_ERR(cd); - return 0; + return PTR_ERR_OR_ZERO(cd); } void dca_sysfs_remove_req(struct dca_provider *dca, int slot) -- 1.9.1