From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753777AbdK1Vkk (ORCPT ); Tue, 28 Nov 2017 16:40:40 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:43725 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbdK1Vkh (ORCPT ); Tue, 28 Nov 2017 16:40:37 -0500 X-Google-Smtp-Source: AGs4zMZ3r4TaF0K8HXjxHTn4ujxldP17bH35+jaxE01uxDtyuOdpyxXRRqbLdPf2KDXaAtS0upepjw== From: Vasyl Gomonovych To: somlo@cmu.edu, mst@redhat.com, qemu-devel@nongnu.org Cc: linux-kernel@vger.kernel.org, gomonovych@gmail.com Subject: [PATCH] firmware: Use PTR_ERR_OR_ZERO() Date: Tue, 28 Nov 2017 22:40:27 +0100 Message-Id: <1511905227-30292-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix ptr_ret.cocci warnings: drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych --- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 5cfe39f7a45f..18489b6a696d 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp) */ fw_cfg_cmdline_dev = platform_device_register_simple("fw_cfg", PLATFORM_DEVID_NONE, res, processed); - if (IS_ERR(fw_cfg_cmdline_dev)) - return PTR_ERR(fw_cfg_cmdline_dev); - return 0; + return PTR_ERR_OR_ZERO(fw_cfg_cmdline_dev); } static int fw_cfg_cmdline_get(char *buf, const struct kernel_param *kp) -- 1.9.1