From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbdLACXQ (ORCPT ); Thu, 30 Nov 2017 21:23:16 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:26655 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751007AbdLACXP (ORCPT ); Thu, 30 Nov 2017 21:23:15 -0500 X-UUID: 7ccf4e89dc554791a80ba3e1d0dec753-20171201 Message-ID: <1512094991.28444.11.camel@mtkswgap22> Subject: Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC From: Sean Wang To: Rob Herring CC: , , , , , Date: Fri, 1 Dec 2017 10:23:11 +0800 In-Reply-To: <20171201020604.etfzccuwomxgcwmg@rob-hp-laptop> References: <3e2c72d18bbe6d7c762fd820195f0fa0b5a45bbf.1511949769.git.sean.wang@mediatek.com> <20171201020604.etfzccuwomxgcwmg@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-30 at 20:06 -0600, Rob Herring wrote: > On Wed, Nov 29, 2017 at 06:10:35PM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Sean Wang > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 72d2a73..1732588 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -12,6 +12,8 @@ Required properties: > > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > + "mediatek,mt7623-mmc", > > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt7623 > > Those should be on 1 line ideally. > > BTW, I find "for mmc host ip compatible with mt7623" to be mostly > redundant. > Either way, > > Acked-by: Rob Herring > > okay, thanks for your careful guide These will be fixed with "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC in the next version Sean > > - reg: physical base address of the controller and length > > - interrupts: Should contain MSDC interrupt number > > - clocks: Should contain phandle for the clock feeding the MMC controller > > -- > > 2.7.4 > > >