From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbdLFOwl (ORCPT ); Wed, 6 Dec 2017 09:52:41 -0500 Received: from smtprelay0146.hostedemail.com ([216.40.44.146]:53576 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752034AbdLFOwh (ORCPT ); Wed, 6 Dec 2017 09:52:37 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:2729:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4225:4250:4321:4605:5007:7875:7901:7903:10004:10400:10848:11232:11658:11914:12043:12296:12740:12760:12895:13019:13069:13095:13311:13357:13439:14096:14097:14180:14181:14659:14721:21063:21080:21324:21433:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: coil85_8b12c80ef9d01 X-Filterd-Recvd-Size: 1722 Message-ID: <1512571954.16419.12.camel@perches.com> Subject: Re: Checkpatch ignores spelling error by using -f From: Joe Perches To: Rolf Evers-Fischer , apw@canonical.com, linux-kernel@vger.kernel.org Date: Wed, 06 Dec 2017 06:52:34 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote: > Hello, > I've just checked the file drivers/tty/serial/8250/8250_omap.c, using > checkpatch.pl, but I forgot the '-f' option (for file). > > Surprisingly the checkpatch script reported a misspelling: > > "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'? > #417: > * We enable TRIG_GRANU for RX and TX and additionaly we set" > > Additionally it reported that the file does not appear to be a > unified-diff (due to my mistake). > > Running checkpatch again with '-f', it didn't report any problems: > > "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is > ready for submission." > > Is this a bug in checkpatch.pl? Or is it a feature? feature. kinda. checkpatch reports spelling errors in commit messages. Without the -f, checkpatch is reading its input as a commit message before expecting to find a diff/patch.