From: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
To: <vinod.koul@intel.com>, <dan.j.williams@intel.com>,
<michal.simek@xilinx.com>, <appanad@xilinx.com>, <sr@denx.de>,
<dave.jiang@intel.com>, <kedare06@gmail.com>
Cc: <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 4/4] dmaengine: zynqmp_dma: Fix race condition in the probe
Date: Thu, 7 Dec 2017 10:54:28 +0530 [thread overview]
Message-ID: <1512624268-13944-5-git-send-email-appanad@xilinx.com> (raw)
In-Reply-To: <1512624268-13944-1-git-send-email-appanad@xilinx.com>
Incase of interrupt property is not present,
Driver is trying to free an invalid irq,
This patch fixes it by adding a check before freeing the irq.
Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
---
Changes for v2:
--> New patch.
drivers/dma/xilinx/zynqmp_dma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index a297a26..f146458 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -851,7 +851,8 @@ static void zynqmp_dma_chan_remove(struct zynqmp_dma_chan *chan)
if (!chan)
return;
- devm_free_irq(chan->zdev->dev, chan->irq, chan);
+ if (chan->irq)
+ devm_free_irq(chan->zdev->dev, chan->irq, chan);
tasklet_kill(&chan->tasklet);
list_del(&chan->common.device_node);
}
--
2.7.4
next prev parent reply other threads:[~2017-12-07 5:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 5:24 [PATCH v2 0/4] dmaengine: zynqmp_dma: Bug fixes Kedareswara rao Appana
2017-12-07 5:24 ` [PATCH v2 1/4] dmaengine: zynqmp_dma: Fix kernel doc-format Kedareswara rao Appana
2017-12-07 5:24 ` [PATCH v2 2/4] dmaengine: zynqmp_dma: Fix warning variable 'val' set but not used Kedareswara rao Appana
2017-12-07 5:24 ` [PATCH v2 3/4] dmaengine: zynqmp_dma: Fix issues with overflow interrupt Kedareswara rao Appana
2017-12-07 5:24 ` Kedareswara rao Appana [this message]
2017-12-18 4:07 ` [PATCH v2 0/4] dmaengine: zynqmp_dma: Bug fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512624268-13944-5-git-send-email-appanad@xilinx.com \
--to=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kedare06@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=sr@denx.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®