From: "David S. Miller" <davem@redhat.com>
To: Tim Hockin <thockin@sun.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
alan@redhat.com
Subject: Re: [PATCH] save source address on accept()
Date: Thu, 31 May 2001 20:42:58 -0700 (PDT) [thread overview]
Message-ID: <15127.3906.773953.16829@pizda.ninka.net> (raw)
In-Reply-To: <3B16EFE0.D0C44FB8@sun.com>
In-Reply-To: <3B16EFE0.D0C44FB8@sun.com>
Tim Hockin writes:
> attached is a (small) patch which saves the src address on tcp_accept().
> Please let me know if there are any problems taking this for general
> inclusion.
..
> --- dist-2.4.5/net/ipv4/tcp.c Wed May 16 10:31:27 2001
> +++ cobalt-2.4.5/net/ipv4/tcp.c Thu May 31 14:33:23 2001
> @@ -2138,6 +2138,7 @@
> tp->accept_queue_tail = NULL;
>
> newsk = req->sk;
> + newsk->rcv_saddr = req->af.v4_req.loc_addr;
> tcp_acceptq_removed(sk);
> tcp_openreq_fastfree(req);
> BUG_TRAP(newsk->state != TCP_SYN_RECV);
Tim, this is in fact completely bogus, it is already being done
in tcp_v{4,6}_syn_recv_sock(), so there is no reason to do the
exact same thing again here in tcp_accept().
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~2001-06-01 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-01 1:29 Tim Hockin
2001-06-01 3:21 ` David S. Miller
2001-06-01 3:42 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15127.3906.773953.16829@pizda.ninka.net \
--to=davem@redhat.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thockin@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®