From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753138AbdLHMXz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Dec 2017 07:23:55 -0500
Received: from smtprelay0233.hostedemail.com ([216.40.44.233]:37514 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752468AbdLHMXx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Dec 2017 07:23:53 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3874:4321:5007:7514:7576:7903:8603:10004:10400:10848:11232:11658:11914:12296:12663:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: boat99_78ec8d69e484c
X-Filterd-Recvd-Size: 2212
Message-ID: <1512735829.1845.15.camel@perches.com>
Subject: Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing
 calculations
From: Joe Perches <joe@perches.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
        Balbir Singh <bsingharora@gmail.com>,
        Colin King <colin.king@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" 
        <linuxppc-dev@lists.ozlabs.org>,
        kernel-janitors@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Fri, 08 Dec 2017 04:23:49 -0800
In-Reply-To: <87efo5h1yh.fsf@concordia.ellerman.id.au>
References: <20171207110134.22566-1-colin.king@canonical.com>
         <CAKTCnzmNKtg1morOPS7D3iGHFxZxd1uioex1eGtChBVppcctKA@mail.gmail.com>
         <87efo5h1yh.fsf@concordia.ellerman.id.au>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-12-08 at 22:51 +1100, Michael Ellerman wrote:
> Balbir Singh <bsingharora@gmail.com> writes:
> 
> > On Thu, Dec 7, 2017 at 10:01 PM, Colin King <colin.king@canonical.com> wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > > 
> > > Use the ARRAY_SIZE macro on several arrays to determine their size.
> > > Improvement suggested by coccinelle.
> > 
> > This file is taken from binutils and re-licensed. Keeping the file
> > as-is helps apply newer patches easily on top as opposed to redoing
> > the changes. I would prefer not to move to ARRAY_SIZE and stick to
> > what's already in the file.
> 
> Yep.
> 
> Thanks but no thanks on this one Colin.
> 
> Is there a checkpatch blacklist anywhere? So we don't keep discovering
> things in this file that need to be fixed?

Nope.  Besides, this came via a coccinelle suggestion.

What might be useful is a generic marker somewhere in
a file that shows the file as a generated file and
indicates the file should not otherwise be modified.