mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: multicast hash incorrect on big endian archs
Date: Sun, 3 Jun 2001 19:24:18 -0700 (PDT)	[thread overview]
Message-ID: <15130.61778.471925.245018@pizda.ninka.net> (raw)
In-Reply-To: <3B1A9558.2DBAECE7@colorfullife.com>
In-Reply-To: <3B1A9558.2DBAECE7@colorfullife.com>


Manfred Spraul writes:
 > I noticed that the multicast hash calculations assumed little endian
 > byte ordering in the winbond-840 driver, and it seems that several other
 > drivers are also affected:
 > 
 > 8139too, epic100, fealnx, pci-skeleton, sis900, starfile, sundance,
 > via-rhine, yellowfin
 > perhaps drivers/net/pcmcia/xircom_tulip_cb

Many big-endian systems already need to provide little-endian bitops,
for ext2's sake for example.

We should formalize this, with {set,clear,change,test}_le_bit which
technically every port has implemented in some for or another already.

Later,
David S. Miller
davem@redhat.com

  reply	other threads:[~2001-06-04  2:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-03 19:51 Manfred Spraul
2001-06-04  2:24 ` David S. Miller [this message]
2001-06-04  7:02   ` Manfred Spraul
2001-06-04  9:35     ` Manfred Spraul
2001-06-04 10:54     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15130.61778.471925.245018@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®