From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050AbdLKOAs (ORCPT ); Mon, 11 Dec 2017 09:00:48 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:40403 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977AbdLKOAo (ORCPT ); Mon, 11 Dec 2017 09:00:44 -0500 X-Google-Smtp-Source: ACJfBouFFaoIveeZFlxfKKJzvOkXFJiNimDW6tirPiFTVXyWb6B15ZuTLtK/C+ska7hu4++ldi4IQw== From: venkat.prashanth2498@gmail.com To: vinod.koul@intel.com, dan.j.williams@intel.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Venkat Prashanth B U Subject: [PATCH] DMA:omap-dma: Fix kernel compilation error and checkpatch issues Date: Mon, 11 Dec 2017 19:30:33 +0530 Message-Id: <1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Venkat Prashanth B U This is the patch to the omap-dma.c file that fixes the following issues: 1.redefinition of 'omap_dma_filter_fn' in the line 1273 of drivers/dma/omap-dma.c 2.drivers/dma/omap-dma.c:341: ERROR: code indent should use tabs where possible reported by ./checkpatch.pl 3.drivers/dma/omap-dma.c:749: WARNING: Missing a blank line after declarations reported by ./checkpatch.pl Signed-off-by: Venkat Prashanth B U --- drivers/dma/omap-dma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index 1dfc71c..2a40485 100644 --- a/drivers/dma/omap-dma.c +++ b/drivers/dma/omap-dma.c @@ -338,7 +338,7 @@ static void omap_dma_stop(struct omap_chan *c) if (val & (CCR_RD_ACTIVE | CCR_WR_ACTIVE)) dev_err(c->vc.chan.device->dev, "DMA drain did not complete on lch %d\n", - c->dma_ch); + c->dma_ch); omap_dma_glbl_write(od, OCP_SYSCONFIG, sysconfig); } else { @@ -746,6 +746,7 @@ static void omap_dma_issue_pending(struct dma_chan *chan) */ if (!c->cyclic) { struct omap_dmadev *d = to_omap_dma_dev(chan->device); + spin_lock(&d->lock); if (list_empty(&c->node)) list_add_tail(&c->node, &d->pending); @@ -1269,7 +1270,7 @@ static struct platform_driver omap_dma_driver = { }, }; -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) +bool omap_dma_filter_func(struct dma_chan *chan, void *param) { if (chan->device->dev->driver == &omap_dma_driver.driver) { struct omap_dmadev *od = to_omap_dma_dev(chan->device); -- 1.9.1