From: Vasyl Gomonovych <gomonovych@gmail.com>
To: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com,
bp@alien8.de, gomonovych@gmail.com, linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI, APEI, Fix use resource_size
Date: Mon, 11 Dec 2017 16:44:31 +0100 [thread overview]
Message-ID: <1513007072-32020-1-git-send-email-gomonovych@gmail.com> (raw)
Use resource_size function on resource object
Underneath __request_region set res->end to start + n - 1
Lets use resourse_size to set value properly.
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/acpi/apei/apei-base.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index da370e1..af712a8 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -506,8 +506,7 @@ int apei_resources_request(struct apei_resources *resources,
rc = -EINVAL;
list_for_each_entry(res, &resources->iomem, list) {
- r = request_mem_region(res->start, res->end - res->start,
- desc);
+ r = request_mem_region(res->start, resource_size(res), desc);
if (!r) {
pr_err(APEI_PFX
"Can not request [mem %#010llx-%#010llx] for %s registers\n",
@@ -519,7 +518,7 @@ int apei_resources_request(struct apei_resources *resources,
}
list_for_each_entry(res, &resources->ioport, list) {
- r = request_region(res->start, res->end - res->start, desc);
+ r = request_region(res->start, resource_size(res), desc);
if (!r) {
pr_err(APEI_PFX
"Can not request [io %#06llx-%#06llx] for %s registers\n",
@@ -542,14 +541,14 @@ int apei_resources_request(struct apei_resources *resources,
list_for_each_entry(res, &resources->ioport, list) {
if (res == res_bak)
break;
- release_region(res->start, res->end - res->start);
+ release_region(res->start, resource_size(res));
}
res_bak = NULL;
err_unmap_iomem:
list_for_each_entry(res, &resources->iomem, list) {
if (res == res_bak)
break;
- release_mem_region(res->start, res->end - res->start);
+ release_mem_region(res->start, resource_size(res));
}
arch_res_fini:
if (arch_apei_filter_addr)
@@ -566,9 +565,9 @@ void apei_resources_release(struct apei_resources *resources)
struct apei_res *res;
list_for_each_entry(res, &resources->iomem, list)
- release_mem_region(res->start, res->end - res->start);
+ release_mem_region(res->start, resource_size(res));
list_for_each_entry(res, &resources->ioport, list)
- release_region(res->start, res->end - res->start);
+ release_region(res->start, resource_size(res));
rc = apei_resources_sub(&apei_resources_all, resources);
if (rc)
--
1.9.1
next reply other threads:[~2017-12-11 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 15:44 Vasyl Gomonovych [this message]
2017-12-13 0:19 ` Rafael J. Wysocki
2017-12-13 15:38 ` Borislav Petkov
2017-12-13 23:07 ` Rafael J. Wysocki
2017-12-14 9:37 ` Borislav Petkov
2017-12-16 10:34 ` Rafael J. Wysocki
2017-12-16 10:43 ` Rafael J. Wysocki
2017-12-16 11:56 ` Borislav Petkov
2017-12-16 15:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513007072-32020-1-git-send-email-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®